Fix Bug 1246

[dreamsxin]

Use imagecreatefromstring replace imagecreatefrompng
See #1246

[ghost]

I am afraid this does not resolve the issue.

valgrind complains that "Conditional jump or move depends on uninitialised value(s)"; this means that you have an if or switch that depends on an uninitialized variable. valgrind suggests that it happens here: phalcon_call_func_p1_ex(image, &image, "imagecreatefrompng", realpath);, however, realpath and image are initialized.

The parent condition is switch (Z_LVAL_P(type)) — it is possible that type is not initialized.

Indeed,

zval *type;

if (phalcon_array_isset_long_fetch(&type, imageinfo, 2)) {
    phalcon_update_property_this(this_ptr, SL("_type"), type TSRMLS_CC);
}

However, if $imageinfo[2] is not set, type will contain garbage and this results in an error.

I would suggest something like this — please check if this is an appropriate solution:

if (phalcon_array_isset_long_fetch(&type, imageinfo, 2)) {
    phalcon_update_property_this(this_ptr, SL("_type"), type TSRMLS_CC);
}
else {
    PHALCON_INIT_VAR(type);
    ZVAL_LONG(type, -1); /* or any other value denoting that the image type is not valid */
}