Update all missing this->_lastKey update for backend cache #12072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update CHANGELOG.md |
|
Why not just do let this->_lastKey = lastKey, they seem the same (would save re-concatenation, not a big deal) |
|
Update the |
| @@ -195,6 +195,7 @@ class Mongo extends Backend implements BackendInterface | |||
| } else { | |||
| let prefix = this->_prefix; | |||
| let lastkey = prefix . keyName; | |||
| let this->_lastKey = lastKey; | |||
|
@hinablue Also could you please rebase |
| * @param long lifetime | ||
| * @param boolean stopBuffer | ||
| */ | ||
| public function save(keyName = null, content = null, lifetime = null, boolean stopBuffer = true) -> boolean |
There was a problem hiding this comment.
Could you please return back tabs instead of spaces?
|
Thanks. Fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
this->_lastKeyupdate for all backend cache.Refs: #12050