Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial support for return_value_ptr to fcall.c and alternative/fcall.c
This will allow us to avoid copy constructors in many cases.
For example, in this case:
currently only
will not waste additional RAM (due to
phalcon_execute_internal
trick) but this will:$s1, $s2, $s3 will use ~5MB each.
The patch adds support for retval_ptr_ptr to fcall.c (the code has to be rewritten to take advantage of retval_ptr_ptr — this optimization cannot be applied transparently without breaking things) and allows functions to take advantage of retval_ptr_ptr if it is available