Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: CriteriaInterface where method differs from implementation method parameter. #15144

Closed
fagai opened this issue Sep 7, 2020 · 1 comment · Fixed by #15146
Closed

[BUG]: CriteriaInterface where method differs from implementation method parameter. #15144

fagai opened this issue Sep 7, 2020 · 1 comment · Fixed by #15146
Assignees
@zsilbi
Labels
bug A bug report

Comments

@fagai
Copy link

fagai commented Sep 7, 2020

Describe the bug

CriteriaInterface where method differs from implementation method parameter.

https://github.com/phalcon/cphalcon/blob/master/phalcon/Mvc/Model/CriteriaInterface.zep#L248

public function where(string! conditions) -> <CriteriaInterface>;

https://github.com/phalcon/cphalcon/blob/master/phalcon/Mvc/Model/Criteria.zep#L808

public function where(string! conditions, var bindParams = null, var bindTypes = null) -> <CriteriaInterface>

Details

  • Phalcon version: 4.0.6
  • PHP Version: PHP 7.4.10
  • Operating System: debian(docker)
  • Installation type: Compiling from source
  • Zephir version (if any):
  • Server: Apache
  • Other related info (Database, table schema):
@fagai fagai added bug A bug report status: unverified Unverified labels Sep 7, 2020
@zsilbi zsilbi removed the status: unverified Unverified label Sep 9, 2020
@zsilbi zsilbi self-assigned this Sep 9, 2020
@zsilbi zsilbi added the 4.1.0 label Sep 10, 2020
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 10, 2020
@zsilbi
fix(model): interface parameters
32d2669 
Refs phalcon#15144
@zsilbi zsilbi mentioned this issue Sep 10, 2020
Merged
3 tasks
zsilbi added a commit to zsilbi/cphalcon that referenced this issue Sep 10, 2020
@zsilbi
fix(model): interface parameters
ac7cf2e 
Refs phalcon#15144
@zsilbi zsilbi linked a pull request Sep 11, 2020 that will close this issue
T15144 CriteriaInterface params fixed #15146
Merged
3 tasks
@zsilbi
Copy link
Member

zsilbi commented Sep 11, 2020

Fixed in #15146

@zsilbi zsilbi closed this as completed Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsilbi zsilbi

Labels
bug A bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15144 CriteriaInterface params fixed zsilbi/cphalcon
2 participants
@fagai @zsilbi