Skip to content

Commit

Permalink
Merge pull request #1381 from sjinks/issue-1379
Browse files Browse the repository at this point in the history
Fix #1379
  • Loading branch information
Phalcon committed Oct 15, 2013
2 parents b3a088a + bc57595 commit cb714c4
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion ext/annotations/annot.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ typedef struct _phannot_parser_status {
#define PHANNOT_PARSING_OK 1
#define PHANNOT_PARSING_FAILED 0

extern int phannot_parse_annotations(zval *result, zval *view_code, zval *template_path, zval *line TSRMLS_DC);
int phannot_parse_annotations(zval *result, zval *view_code, zval *template_path, zval *line TSRMLS_DC);
int phannot_internal_parse_annotations(zval **result, zval *view_code, zval *template_path, zval *line, zval **error_msg TSRMLS_DC);
2 changes: 1 addition & 1 deletion ext/mvc/model/query/parser.c
Original file line number Diff line number Diff line change
Expand Up @@ -2827,7 +2827,7 @@ PHALCON_ATTR_NONNULL int phql_parse_phql(zval *result, zval *phql TSRMLS_DC) {
/**
* Executes a PHQL parser/tokenizer
*/
PHALCON_ATTR_NONNULL2(1, 4) int phql_internal_parse_phql(zval **result, char *phql, unsigned int phql_length, zval **error_msg TSRMLS_DC) {
int phql_internal_parse_phql(zval **result, char *phql, unsigned int phql_length, zval **error_msg TSRMLS_DC) {

zend_phalcon_globals *phalcon_globals_ptr = PHALCON_VGLOBAL;
phql_parser_status *parser_status = NULL;
Expand Down
4 changes: 2 additions & 2 deletions ext/mvc/model/query/phql.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@ typedef struct _phql_parser_status {
#define PHQL_PARSING_OK 1
#define PHQL_PARSING_FAILED 0

PHALCON_ATTR_NONNULL int phql_parse_phql(zval *result, zval *phql TSRMLS_DC);
PHALCON_ATTR_NONNULL2(1, 4) int phql_internal_parse_phql(zval **result, char *phql, unsigned int phql_length, zval **error_msg TSRMLS_DC);
int phql_parse_phql(zval *result, zval *phql TSRMLS_DC) PHALCON_ATTR_NONNULL;
int phql_internal_parse_phql(zval **result, char *phql, unsigned int phql_length, zval **error_msg TSRMLS_DC) PHALCON_ATTR_NONNULL2(1, 4);
4 changes: 2 additions & 2 deletions ext/mvc/view/engine/volt/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,10 @@ int phvolt_parse_view(zval *result, zval *view_code, zval *template_path TSRMLS_

if (phvolt_internal_parse_view(&result, view_code, template_path, &error_msg TSRMLS_CC) == FAILURE) {
if (likely(error_msg != NULL)) {
PHALCON_THROW_EXCEPTION_STR(phalcon_mvc_view_exception_ce, Z_STRVAL_P(error_msg));
PHALCON_THROW_EXCEPTION_STRW(phalcon_mvc_view_exception_ce, Z_STRVAL_P(error_msg));
}
else {
PHALCON_THROW_EXCEPTION_STR(phalcon_mvc_view_exception_ce, "Error parsing the view");
PHALCON_THROW_EXCEPTION_STRW(phalcon_mvc_view_exception_ce, "Error parsing the view");
}

return FAILURE;
Expand Down
4 changes: 2 additions & 2 deletions ext/mvc/view/engine/volt/parser.c
Original file line number Diff line number Diff line change
Expand Up @@ -3455,10 +3455,10 @@ int phvolt_parse_view(zval *result, zval *view_code, zval *template_path TSRMLS_

if (phvolt_internal_parse_view(&result, view_code, template_path, &error_msg TSRMLS_CC) == FAILURE) {
if (likely(error_msg != NULL)) {
PHALCON_THROW_EXCEPTION_STR(phalcon_mvc_view_exception_ce, Z_STRVAL_P(error_msg));
PHALCON_THROW_EXCEPTION_STRW(phalcon_mvc_view_exception_ce, Z_STRVAL_P(error_msg));
}
else {
PHALCON_THROW_EXCEPTION_STR(phalcon_mvc_view_exception_ce, "Error parsing the view");
PHALCON_THROW_EXCEPTION_STRW(phalcon_mvc_view_exception_ce, "Error parsing the view");
}

return FAILURE;
Expand Down

0 comments on commit cb714c4

Please sign in to comment.