Merge pull request #13496 from cq-z/filename_error

Filename error
phalcon · Oct 4, 2018 · 72cfb5e · 72cfb5e
2 parents d472fe2 + 0479ee5
commit 72cfb5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG-3.4.md b/CHANGELOG-3.4.md
@@ -1,5 +1,6 @@
 # [3.4.2](https://github.com/phalcon/cphalcon/releases/tag/v3.4.2) (2018-XX-XX)
 - Fixed `Phalcon\Validation\Validator\Numericality` to accept float numbers on locales with comma decimal point [#13450](https://github.com/phalcon/cphalcon/issues/13450)
+- Fixed  `\Phalcon\Http\Response::setFileToSend` filename last much _ 
 
 # [3.4.1](https://github.com/phalcon/cphalcon/releases/tag/v3.4.1) (2018-08-04)
 - Changed `Phalcon\Cache\Backend\Redis` to support connection timeout parameter

diff --git a/phalcon/http/response.zep b/phalcon/http/response.zep
@@ -664,7 +664,7 @@ class Response implements ResponseInterface, InjectionAwareInterface
 		if attachment {
 			this->setRawHeader("Content-Description: File Transfer");
 			this->setRawHeader("Content-Type: application/octet-stream");
-			this->setRawHeader("Content-Disposition: attachment; filename=" . basePath);
+			this->setRawHeader("Content-Disposition: attachment; filename=" . basePath . ";");
 			this->setRawHeader("Content-Transfer-Encoding: binary");
 		}