Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing args to initETE3Database #142

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

dfornika
Copy link
Contributor

@dfornika dfornika commented Jun 20, 2023

Fixes #141

I've standardized all call sites to initETE3Database() to pass database_directory and ETE3DBTAXAFILE.

I've also added database_directory as an argument to NamesToTaxIDs(), so it can be passed along to initETE3Database().

I've also modified the function signatures and call sites to other functions that call initETE3Database():

  • getHeirarchy()
  • getTaxid()
  • getTaxonConvergence()

I've removed logging as an argument to initETE3Database() as it doesn't appear to be necessary.

@dfornika dfornika marked this pull request as draft June 20, 2023 22:59
@dfornika dfornika marked this pull request as ready for review June 20, 2023 23:15
@jrober84 jrober84 merged commit af3014b into phac-nml:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in mob_cluster NamesToTaxIDs
2 participants