Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch intigration tests to launch irida via gradle #140

Merged
merged 3 commits into from
Jul 7, 2022
Merged

switch intigration tests to launch irida via gradle #140

merged 3 commits into from
Jul 7, 2022

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented Jun 29, 2022 •
edited
Loading

Description of changes

integration tests launch irida with gradle to match phac-nml/irida#1319

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@JeffreyThiessen JeffreyThiessen mentioned this pull request Jun 29, 2022
Merged
ericenns
ericenns requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

README.md Outdated Show resolved Hide resolved
iridauploader/tests_integration/integration_data_setup.py Show resolved Hide resolved
ericenns
ericenns approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks good to me. Once the IRIDA 22.07 release is finalized and pushed, tests against master will pass again.

@ericenns ericenns merged commit e1f0974 into development Jul 7, 2022
@ericenns ericenns deleted the int_tests_gradle branch July 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericenns ericenns ericenns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffreyThiessen @ericenns