Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Uploader UI access error #979

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Mar 11, 2025

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR updates the logic so that a user with access level uploader gets an access denied message (instead of an error message) when attempting to do an action (e.g. access a project or group that they are a member of)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a project and add a user with access level uploader
  2. Logout and login as this user, and try to access the project. You should get an access denied error page
  3. Repeat 1 and 2 for a group
  4. Verify the tests pass

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

…ader access level tries to access a project or group that they are a member of
@deepsidhu85 deepsidhu85 changed the title Updated logic to display access denied message if a user with an uplo… Fix: Uploader UI access error Mar 11, 2025
Copy link

Code Metrics Report

Coverage Test Execution Time
94.7% 11m50s

Code coverage of files in pull request scope (93.8%)

Files Coverage
app/policies/group_policy.rb 91.4%
app/policies/project_policy.rb 96.9%

Reported by octocov

@deepsidhu85 deepsidhu85 requested a review from ericenns March 11, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant