Refactor project activity components #936
Draft
+345
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to only have a link to a project namespace if it has not been deleted
…ing a link), added translations, added new method get_object_by_puid to track activity concern
…up activity will be in a followup pr
deepsidhu85
force-pushed
the
refactor-activities-project
branch
from
07164d3 to
40c6a5f
Compare
…updated component comments, updated workflow execution activity to only have clickable link if the workflow execution still exists, updated track activity concern methods to get object to work with and without acts with paranoid models
…lready contains it
This comment has been minimized.
This comment has been minimized.
…ll be used in the display rather than getting the puid from the namespace object which could be nil if it is permanently deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
Refactored project activities into individual components and updated to only have a link to a project namespace if it has not been deleted
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.