Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PG16 stringToQualifiedNameList #339

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

robe2
Copy link
Contributor

@robe2 robe2 commented Aug 13, 2023

Closes #338

This fixes the stringToQualifiedNameList

Technically that NULL should be NIL, but then I'd need to drag in another include to use NIL

Sadly the tests still don't all pass. The pointcloud test is failing on my system:

# using postmaster on localhost, port 5453
not ok 1     - pointcloud                                326 ms
ok 2         - pointcloud_columns                        116 ms
ok 3         - schema                                     54 ms
1..3

At a glance the issue is a harmless one.

For example for the test:

-- test PC_SetPCId
-- from pcid 1 to 1 (same dimensions, same positions, same compressions)
-- pcid 1: (X,Y,Z,I), scaled, uncompressed
SELECT
  PC_AsText(PC_SetPCId(p, 1)) t, PC_Summary(PC_SetPCId(p, 1))::json->'compr' c
FROM ( SELECT PC_Patch(PC_MakePoint(1, ARRAY[-1,0,4862413,1])) p ) foo;

The expected result is:

                    t                    |   c    
-----------------------------------------+--------
 {"pcid":1,"pts":[[-1,0,4.86241e+06,1]]} | "none"

But I'm getting below on my mingw64 gcc 8.1, PG16 beta2

                    t                     |   c    
------------------------------------------+--------
 {"pcid":1,"pts":[[-1,0,4.86241e+006,1]]} | "none"

Thought this might be a mingw64 issue, I'm going to add test in a separate pull request to check

@robe2
Copy link
Contributor Author

robe2 commented Aug 13, 2023

Okay I was able to setup CI for pg16, the issue with the output difference is only mingw64, so guess can be ignored for now.

@pblottiere pblottiere mentioned this pull request Aug 14, 2023
@pblottiere pblottiere merged commit 553a137 into pgpointcloud:master Aug 24, 2023
12 checks passed
bob-beck pushed a commit to openbsd/ports that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PG16: error: too few arguments to function ‘stringToQualifiedNameList’
2 participants