Fix for PG16 stringToQualifiedNameList #339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #338
This fixes the stringToQualifiedNameList
Technically that NULL should be NIL, but then I'd need to drag in another include to use NIL
Sadly the tests still don't all pass. The pointcloud test is failing on my system:
At a glance the issue is a harmless one.
For example for the test:
The expected result is:
But I'm getting below on my mingw64 gcc 8.1, PG16 beta2
Thought this might be a mingw64 issue, I'm going to add test in a separate pull request to check