Initialize reason and SQLState in PostgresqlServerErrorException. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now initialize reason and SQLState properties of R2dbcException to provide details for code that uses only R2dbcException. We're aligning the behavior with the JDBC driver that only populates SQLState and leaves errorCode empty. Closes gh-3.
Previously, the implementation of this iterated over the collection of fields three times. This change iterates a single time to convert to a Map, which then is used for efficient lookup.
|
Looks better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now initialize reason and SQLState properties of R2dbcException
to provide details for code that uses only R2dbcException.
We're aligning the behavior with the JDBC driver that only
populates SQLState and leaves errorCode empty.
Closes gh-3.