fix(framework-examples): Fix VueJS lifecycle beforeDestroy hooks (mat…

…erial-components#417) Resolves material-components#416
pgbross · Mar 23, 2017 · 0115498 · 0115498
1 parent 73448f9
commit 0115498
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/framework-examples/vue/src/App.vue b/framework-examples/vue/src/App.vue
@@ -62,8 +62,16 @@
     </div>
     <button type="button" @click="showSnackbar">Show Snackbar</button>
     <snackbar event='mailSent'></snackbar>
-
+    <div>
+      <p>
+        <form-field :align-end='alignEnd'>
+          <checkbox v-model="showIcon" label="Show toggle" id="my-show" label-id="my-show-label"></checkbox>
+          <checkbox-label id="my-show-label" for="my-show" :label="showLabel"></checkbox-label>
+        </form-field>
+      </p>
+    </div>
     <icon-toggle v-model="favorited"
+                 v-if="showIcon"
                  :toggle-on="{'label': favoritedLabel, 'content': 'favorite'}"
                  :toggle-off="{'label': 'Add to favorites', 'content': 'favorite_border'}">
     </icon-toggle>
@@ -95,7 +103,9 @@ export default {
       alignEnd: false,
       changeCount: 0,
       favorited: true,
-      favoritedLabel: 'Remove from favorites'
+      favoritedLabel: 'Remove from favorites',
+      showIcon: true,
+      showLabel: 'Hide icon toggle'
     }
   },
   components: { FormField, Checkbox, CheckboxLabel, IconToggle, Snackbar, TemporaryDrawer },

diff --git a/framework-examples/vue/src/v-mdc-checkbox/Checkbox.vue b/framework-examples/vue/src/v-mdc-checkbox/Checkbox.vue
@@ -68,7 +68,7 @@ export default {
     });
     this.foundation.init();
   },
-  beforeUnmount () {
+  beforeDestroy () {
     this.foundation.destroy();
   },
   methods: {

diff --git a/framework-examples/vue/src/v-mdc-drawer/TemporaryDrawer.vue b/framework-examples/vue/src/v-mdc-drawer/TemporaryDrawer.vue
@@ -102,7 +102,7 @@ export default {
     });
     this.foundation.init();
   },
-  beforeUnmount () {
+  beforeDestroy () {
     this.foundation.destroy();
   },
   methods: {

diff --git a/framework-examples/vue/src/v-mdc-icon-toggle/IconToggle.vue b/framework-examples/vue/src/v-mdc-icon-toggle/IconToggle.vue
@@ -73,7 +73,7 @@ export default {
     this.foundation.init();
     this.foundation.toggle(this.value);
   },
-  beforeUnmount () {
+  beforeDestroy () {
     this.foundation.destroy();
   },
   watch: {

diff --git a/framework-examples/vue/src/v-mdc-snackbar/Snackbar.vue b/framework-examples/vue/src/v-mdc-snackbar/Snackbar.vue
@@ -83,7 +83,7 @@ export default {
       this.foundation.show(data)
     });
   },
-  beforeUnmount () {
+  beforeDestroy () {
     this.foundation.destroy();
   },
   methods: {