Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NULLS FIRST/LAST to ORDER BY deparse #95

Merged
merged 2 commits into from Sep 20, 2018
Merged

Add NULLS FIRST/LAST to ORDER BY deparse #95

merged 2 commits into from Sep 20, 2018

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Sep 19, 2018

This fixes #94

@herwinw
Copy link
Contributor Author

herwinw commented Sep 19, 2018

(Note to self: Case 159936)

lfittl
lfittl approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great!

@lfittl lfittl merged commit 6150b7d into pganalyze:master Sep 20, 2018
@herwinw herwinw deleted the orderby_nulls branch September 20, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfittl lfittl lfittl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deparse skips NULLS FIRST/LAST in ORDER BY
3 participants
@herwinw @lfittl @qnet-herwin