Use Integer class for checking integer instead of Fixnum #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Fixnum and Bignum are unfied into Integer in Ruby 2.4+, a warning occurs for using Fixnum (or Bignum).
json 1.8.3 cannot be build with Ruby 2.4
lfittl
reviewed
Feb 10, 2017
| @@ -22,7 +22,7 @@ def from(item) | |||
|
|
|||
| def deparse_item(item, context = nil) # rubocop:disable Metrics/CyclomaticComplexity | |||
| return if item.nil? | |||
| return item if item.is_a?(Fixnum) | |||
| return item if item.is_a?(Integer) | |||
There was a problem hiding this comment.
Do we need a version-check for the Ruby version here?
(this might not be tested by the test suite right now)
There was a problem hiding this comment.
I think this works with any version rubies.
- In ruby 2.3.x or older,
Integerclass is an ancestor ofFixnumandBignum. - In ruby 2.4+, all integers are
Integerclass.
So item.is_a?(Integer) works in both cases.
Supporting Bignum in older rubies is a difference, but it may work as intended.
There was a problem hiding this comment.
Ah, yes, you are indeed correct!
|
@makimoto I think updating it in the Gemfile.lock is fine. You are correct that we don't necessarily need that in a library, but its useful to have the tests run with predictable versions. |
OK. I got it. |
|
@makimoto Merged - thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Fixnum and Bignum are unfied into Integer in Ruby 2.4+, a warning
occurs for using Fixnum (or Bignum).