Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on BSD systems #58

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Fix build on BSD systems #58

merged 1 commit into from
Dec 6, 2016

Conversation

valpackett
Copy link
Contributor

I guess there might be a better way to run the same make that create_makefile runs?? But this will do.

@lfittl
Copy link
Member

lfittl commented Dec 6, 2016

@myfreeweb Thanks for the contribution!

For clarification, this make invocation isn't for the Makefile thats generated by extconf itself, but rather for building a C language library the gem depends on for parsing.

Since I don't have FreeBSD readily available for testing, just to confirm, this works correctly on your machine?

@valpackett
Copy link
Contributor Author

Yeah. The makefile that's generated by extconf works fine (it's either compatible with BSD make, or executed by gmake). The makefile of the library requires GNU make, so gmake needs to be run instead of make. It works fine on my machine, yes.

@lfittl lfittl merged commit 716a2eb into pganalyze:master Dec 6, 2016
@lfittl
Copy link
Member

lfittl commented Dec 6, 2016

@myfreeweb Excellent, thanks for confirming - merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants