Deparse constraints #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. "CONSTRAINT name_length PRIMARY KEY (name, length)"
This one is a bit tricky. PG packs the interval parts into a single integer and it does so according to a very specific set of combinations enumerated in the grammar. There was no straightforward way to recompose the original SQL - we have to use a map of known values.
| def self.from_int(int) | ||
| SQL_BY_MASK[int] | ||
| end | ||
| end |
There was a problem hiding this comment.
Nice work 👌
This reminds me, we should split the deparsing into multiple files (based on node type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deparsing of complex types (like
interval day to second(2)) and constraints on table creation.