Fix Alter .. RENAME SQL #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2019 14:26
CREATE DOMAIN us_postal_code AS TEXT
CHECK(
VALUE ~ '^\d{5}$'
OR VALUE ~ '^\d{5}-\d{4}$'
);
`deparse_renamestmt': Can't deparse: {"renameType"=>47, "relationType"=>0, "relation"=>{"RangeVar"=>{"relname"=>"foo", "inh"=>true, "relpersistence"=>"p", "location"=>11}}, "newname"=>"bar", "behavior"=>0} (RuntimeError)
ALTER VIEW "foo" RENAME TO "bar"
`deparse_renamestmt': Can't deparse: {"renameType"=>47, "relationType"=>0, "relation"=>{"RangeVar"=>{"relname"=>"foo", "inh"=>true, "relpersistence"=>"p", "location"=>11}}, "newname"=>"bar", "behavior"=>0} (RuntimeError)
ALTER VIEW "foo" RENAME TO "bar"
lfittl
reviewed
Jul 1, 2019
lib/pg_query/deparse.rb
Outdated
| output << deparse_item(node['relation']) | ||
| output << 'RENAME TO' | ||
| output << node['newname'] | ||
| output << deparse_identifier(node['newname'], escape_always: true) |
There was a problem hiding this comment.
Can you clarify why we need to escape this one always?
I mostly added that as a legacy option to avoid breaking too many tests, but I think going forward this should not be used if we can avoid it.
There was a problem hiding this comment.
ALTER VIEW "foo" RENAME TO "Bar"
if execute this sql without (escape_always: true) options, deparser result is ALTER VIEW "foo" RENAME TO Bar. If you execute deparser sql, rename the view as a bar not Bar.
So we need this options.
added 2 commits
July 8, 2019 02:05
ALTER TRIGGER "emp_stamp" ON "emp" RENAME TO "emp_track_chgs" ALTER FUNCTION "sqrt"(int) RENAME TO "square_root" ALTER MATERIALIZED VIEW "foo" RENAME TO "bar" ALTER CONVERSION "iso_8859_1_to_utf8" RENAME TO "latin1_to_unicode" ALTER DOMAIN "zipcode" RENAME CONSTRAINT zipchk TO "zip_check" ALTER COLLATION "de_DE" RENAME TO "german" ALTER AGGREGATE "myavg"(int) RENAME TO "my_average" ALTER TABLE "distributors" RENAME COLUMN address TO "city" ALTER TABLE "distributors" RENAME CONSTRAINT zipchk TO "zip_check" ALTER TYPE "electronic_mail" RENAME TO "email" ALTER INDEX "distributors" RENAME TO "suppliers" ALTER TABLESPACE index_space RENAME TO "fast_raid" ALTER TRIGGER "emp_stamp" ON "emp" RENAME TO "emp_track_chgs" ALTER RULE notify_all ON "emp" RENAME TO "notify_me"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALTER TRIGGER "emp_stamp" ON "emp" RENAME TO "emp_track_chgs"
ALTER FUNCTION "sqrt"(int) RENAME TO "square_root"
ALTER MATERIALIZED VIEW "foo" RENAME TO "bar"
ALTER CONVERSION "iso_8859_1_to_utf8" RENAME TO "latin1_to_unicode"
ALTER DOMAIN "zipcode" RENAME CONSTRAINT zipchk TO "zip_check"
ALTER COLLATION "de_DE" RENAME TO "german"
ALTER AGGREGATE "myavg"(int) RENAME TO "my_average"
ALTER TABLE "distributors" RENAME COLUMN address TO "city"
ALTER TABLE "distributors" RENAME CONSTRAINT zipchk TO "zip_check"
ALTER TYPE "electronic_mail" RENAME TO "email"
ALTER INDEX "distributors" RENAME TO "suppliers"
ALTER TABLESPACE index_space RENAME TO "fast_raid"
ALTER TRIGGER "emp_stamp" ON "emp" RENAME TO "emp_track_chgs"
ALTER RULE notify_all ON "emp" RENAME TO "notify_me"