Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILIKE,COLLATE and DISCARD deparse #133

Merged
merged 6 commits into from
May 6, 2019
Merged

ILIKE,COLLATE and DISCARD deparse #133

merged 6 commits into from
May 6, 2019

Conversation

emin100
Copy link
Contributor

@emin100 emin100 commented Apr 2, 2019

Deparse exception for ILIKE statements and COLLATE. I fix it. Now we can use ILIKE statements and COLLATE.

mehmet emin karakas added 2 commits April 2, 2019 12:25
SELECT 'foo' COLLATE "tr_TR";
SELECT * FROM test1 ORDER BY name COLLATE "tr_TR" DESC;
@emin100 emin100 changed the title ILIKE deparse problem ILIKE and COLLATE deparse problem Apr 4, 2019
SELECT 'foo' COLLATE "tr_TR";
SELECT * FROM test1 ORDER BY name COLLATE "tr_TR" DESC;
@herwinw
Copy link
Contributor

herwinw commented Apr 27, 2019

Could you include some unit tests?

@emin100
Copy link
Contributor Author

emin100 commented Apr 29, 2019

I added some unit tests.

@emin100 emin100 changed the title ILIKE and COLLATE deparse problem ILIKE,COLLATE and DISCARD deparse May 2, 2019
@lfittl
Copy link
Member

lfittl commented May 6, 2019

Thanks for the contribution!

@lfittl lfittl merged commit 374c297 into pganalyze:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants