(de?)parse fails

[benchub]

print PgQuery.parse("update foo set a=?, b=?").deparse

drops the comma, resulting in invalid sql

[lfittl]

@benchub Thanks for opening the issues regarding deparsing!

Your help would be very welcome in fixing these, the logic is in https://github.com/lfittl/pg_query/blob/master/lib/pg_query/deparse.rb and shouldn't be too hard to understand. We should also make sure to add tests for each of these cases, so it doesn't regress in a future Postgres version.

[benchub]

To be honest I was hoping to see how you fixed them while I got the rest of my stuff in order. :) And what I really need is to figure out how to do it all the go library, anyway. Which, doesn't look to be hard… just drudgery.

…

On Sep 7, 2018, at 9:42 AM, Lukas Fittl ***@***.***> wrote: @benchub <https://github.com/benchub> Thanks for opening the issues regarding deparsing! Your help would be very welcome in fixing these, the logic is in https://github.com/lfittl/pg_query/blob/master/lib/pg_query/deparse.rb <https://github.com/lfittl/pg_query/blob/master/lib/pg_query/deparse.rb> and shouldn't be too hard to understand. We should also make sure to add tests for each of these cases, so it doesn't regress in a future Postgres version. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABzq-iRGQ4tl_XC_4eEZCK36ABWLV6t0ks5uYqHegaJpZM4WUGcL>.