Update Postgres to 13.8 and backport bc7a40b4 to fix new Xcode build #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfittl
force-pushed
the
13-latest-update-to-13-8-with-xcode-fix
branch
from
2095eff
to
e636bd7
Compare
See https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us for discussion of the Xcode build issue. Fixed in bc7a40b4, which is on REL_13_STABLE but not yet in an official Postgres release. In passing this also fixes a extract source issue with newer clang versions.
lfittl
force-pushed
the
13-latest-update-to-13-8-with-xcode-fix
branch
from
e636bd7
to
d8aa3cc
Compare
msakrejda
approved these changes
Nov 2, 2022
| # There seems to be a bug here on modern Clang versions where the | ||
| # cursor kind gets modified once we call "child_cursor.definition" | ||
| # - thus we make a copy ahead of calling that, for later use | ||
| child_cursor_kind = child_cursor.kind |
There was a problem hiding this comment.
Maybe? I think the issue here is likely in the Ruby binding, which is semi-maintained.
Its a bit of a time sink to reproduce this, so I'll punt on this for now.
fantix
added a commit
to edgedb/edgedb
that referenced
this pull request
Nov 14, 2022
This fixes a build failure on macOS with SDK 13.0, refs: * postgres/postgres@717ec1a * pganalyze/libpg_query#156
fantix
added a commit
to edgedb/edgedb
that referenced
this pull request
Nov 14, 2022
This fixes a build failure on macOS with SDK 13.0, refs: * postgres/postgres@717ec1a * pganalyze/libpg_query#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://postgr.es/m/1803927.1665938411@sss.pgh.pa.us for discussion of the Xcode build issue. Fixed in bc7a40b4, which is on REL_13_STABLE but not yet in an official Postgres release.
In passing this also fixes an extract source script issue with newer clang versions.
Fixes pganalyze/pg_query#263