Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORDER BY selecting for clients #744

Closed
wants to merge 9 commits into from
Closed

Conversation

visill
Copy link
Contributor

@visill visill commented Aug 19, 2024

No description provided.

@reshke
Copy link
Collaborator

reshke commented Aug 20, 2024

general coding done ok.
however test needed here. You can use mock generator to get one

Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the result is very large (for example, several hundred million rows) and does not fit into the router's memory?

There is 2 options here:

  • do not crash and produce correct result (any ideas how?)
  • return an error or explicitly somehow report that the response is too large

And we need tests for extremely large response situation.

@visill
Copy link
Contributor Author

visill commented Aug 28, 2024

@visill visill requested a review from Denchick August 28, 2024 07:42
@visill
Copy link
Contributor Author

visill commented Sep 2, 2024

#753

@visill visill closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants