Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tx status tracking #343

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix tx status tracking #343

merged 1 commit into from
Dec 4, 2023

Conversation

reshke
Copy link
Collaborator

@reshke reshke commented Dec 4, 2023

psql (15beta1 (Ubuntu 15~beta1-1.pgdg20.04+1), server 15.4)
Type "help" for help.

db1=# commit;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
COMMIT
db1=# commit;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
COMMIT
db1=# commit;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
COMMIT
db1=# begin;
BEGIN
db1=*# commit;
ERROR:  client proccessing error: client relay has no connection to shards, tx status ACTIVE
db1=# begin;
BEGIN
db1=*# begin;
WARNING:  client 0xc0003a81c0: error there is already transaction in progress
BEGIN
db1=*# begin;
WARNING:  client 0xc0003a81c0: error there is already transaction in progress
BEGIN
db1=*# rollback ;
ERROR:  client proccessing error: ddl is forbidden inside multi-shard transition, tx status ACTIVE
db1=# rollback ;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
ROLLBACK
db1=# rollback ;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
ROLLBACK
db1=# rollback ;
WARNING:  client 0xc0003a81c0: error there is no transaction in progress
ROLLBACK
db1=# ^C
db1=# \q

@reshke reshke merged commit aeb8ef5 into master Dec 4, 2023
24 checks passed
Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reshke reshke deleted the txstatus branch January 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants