fix lint

pg-sharding · Sep 8, 2023 · 5375a2e · 5375a2e
1 parent 801cf8a
commit 5375a2e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/balancer/app/app.go b/balancer/app/app.go
@@ -32,9 +32,9 @@ func NewApp(balancer *balancerPkg.Balancer, cfg config.Balancer) (*App, error) {
 	}
 	shardClusters := map[int]*hasql.Cluster{}
 
-	for id, shard := range *shards {
+	for id := range *shards {
 		shardClusters[id], err = balancerPkg.NewCluster(
-			shard.Hosts,
+			(*shards)[id].Hosts,
 			cfg.InstallationDBName,
 			cfg.InstallationUserName,
 			cfg.InstallationPassword,

diff --git a/pkg/coord/adapter.go b/pkg/coord/adapter.go
@@ -216,8 +216,8 @@ func (a *adapter) DropShardingRuleAll(ctx context.Context) ([]*shrule.ShardingRu
 	}
 
 	c := proto.NewShardingRulesServiceClient(a.conn)
-	c.DropShardingRules(ctx, &proto.DropShardingRuleRequest{Id: ids})
-	return rules, nil
+	_, err = c.DropShardingRules(ctx, &proto.DropShardingRuleRequest{Id: ids})
+	return rules, err
 }
 
 func (a *adapter) ListShardingRules(ctx context.Context) ([]*shrule.ShardingRule, error) {

diff --git a/router/console/console.go b/router/console/console.go
@@ -89,7 +89,7 @@ func (l *Local) proxyProc(ctx context.Context, tstmt spqrparser.Statement, cli *
 			if err != nil {
 				return err
 			}
-			conn, err := grpc.Dial(coordAddr, grpc.WithInsecure())
+			conn, err := grpc.Dial(coordAddr, grpc.WithInsecure()) //nolint:all
 			if err != nil {
 				return err
 			}
@@ -102,7 +102,7 @@ func (l *Local) proxyProc(ctx context.Context, tstmt spqrparser.Statement, cli *
 		if err != nil {
 			return err
 		}
-		conn, err := grpc.Dial(coordAddr, grpc.WithInsecure())
+		conn, err := grpc.Dial(coordAddr, grpc.WithInsecure()) //nolint:all
 		if err != nil {
 			return err
 		}

diff --git a/test/feature/spqr_test.go b/test/feature/spqr_test.go
@@ -480,7 +480,7 @@ func (tctx *testContext) stepHostIsStopped(service string) error {
 			return false
 		}
 		addr := strings.Split(output, "\n")[1]
-		conn, err := grpc.Dial(addr, grpc.WithInsecure())
+		conn, err := grpc.Dial(addr, grpc.WithInsecure()) //nolint:all
 		if err != nil {
 			return false
 		}