waitFor return check since waitForText doesn't assert #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexpott
reviewed
Dec 3, 2021
| */ | ||
| public function registerFunctionNames() | ||
| { | ||
| return ['waitForText']; |
There was a problem hiding this comment.
Should we add more of the waitFor* methods?
|
Nice one @smmccabe - this is looking pretty good and very useful. One small question about whether to include the other waitFor* methods. |
klausi
requested changes
Dec 25, 2021
There was a problem hiding this comment.
Thanks, makes sense in general to me. Can we add some safe guards that we do not trigger on the function call waitForText() and that we are in a test class?
I feel like this check would be a better fit for drupalcheck, which can do real semantic analysis with phpstan https://github.com/mglaman/drupal-check
| @@ -0,0 +1,57 @@ | |||
| <?php | |||
| /** | |||
| * Unit test class for the DbQuery sniff. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved version of #145 which was initially only internal. The one has test and matches code standards