Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nn.functional.tanh with torch.tanh #64

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Replace nn.functional.tanh with torch.tanh #64

merged 4 commits into from
Sep 4, 2020

Conversation

prabhatnagarajan
Copy link
Contributor

When I run PFRL code, I get the warning:

/Users/prabhat/miniconda3/envs/pfrl/lib/python3.7/site-packages/torch/nn/functional.py:1558: UserWarning: nn.functional.tanh is deprecated. Use torch.tanh instead.
  warnings.warn("nn.functional.tanh is deprecated. Use torch.tanh instead.")

This is corroborated by https://discuss.pytorch.org/t/torch-tanh-vs-torch-nn-functional-tanh/15897.

@prabhatnagarajan
Copy link
Contributor Author

/test

@github-actions github-actions bot requested a review from ummavi September 4, 2020 05:17
@pfn-ci-bot
Copy link

Successfully created a job for commit 08e23a4:

@github-actions github-actions bot requested a review from marioyc September 4, 2020 07:04
@prabhatnagarajan
Copy link
Contributor Author

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit fe013e4:

marioyc
marioyc approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@marioyc marioyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prabhatnagarajan prabhatnagarajan merged commit 653f858 into pfnet:master Sep 4, 2020
@prabhatnagarajan prabhatnagarajan deleted the tanh_replace branch September 4, 2020 07:24
@muupan muupan added the enhancement New feature or request label Dec 11, 2020
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioyc marioyc marioyc approved these changes

@ummavi ummavi Awaiting requested review from ummavi

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prabhatnagarajan @pfn-ci-bot @marioyc @muupan