Fix CI error due to gym's version #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both atari_py and opencv-python are included in gym[atari].
|
/test |
|
Successfully created a job for commit a628a7c: |
muupan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #158
Why this PR resolves the issue:
gym==0.19.0,pip install gymno longer installpyglet, which causes this error since the monitor functionality of classic control envs requires pyglet.gym[classic_control]so that pyglet is also installed.Both atari_py and opencv-python are included in gym[atari], so it must be safe to stop installing them manually. See https://github.com/openai/gym/blob/a4c3f15e9b0c7525ec9006e92a3bf6bc8bd0a798/setup.py#L11-L19