Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error related to collation and RNN #129

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Fix an error related to collation and RNN #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0878ace
Fix an error related to collation and RNN
tarokiritani Feb 9, 2021
6361123
Update test_batch_states.py
tarokiritani Feb 24, 2021
671b6d6
Update pfrl/utils/batch_states.py
tarokiritani Feb 24, 2021
b5f6907
Update test_batch_states.py
tarokiritani Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pfrl/utils/batch_states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,7 @@ def batch_states(
"""
features = [phi(s) for s in states]
# return concat_examples(features, device=device)
return _to_recursive(default_collate(features), device)
collated_features = default_collate(features)
if isinstance(features[0], tuple):
collated_features = tuple(collated_features)
return _to_recursive(collated_features, device)
7 changes: 3 additions & 4 deletions tests/utils_tests/test_batch_states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import pfrl


@pytest.mark.skip
class TestBatchStates(unittest.TestCase):
def _test(self, gpu):

Expand All @@ -28,17 +27,17 @@ def phi(state):
self.assertIsInstance(batch, tuple)
batch_a, batch_b, batch_c = batch
np.testing.assert_allclose(
batch_a,
batch_a.cpu(),
np.asarray(
[
[[0, 2], [4, 6]],
[[2, 4], [6, 8]],
]
),
)
np.testing.assert_allclose(batch_b, np.asarray([0, 1]))
np.testing.assert_allclose(batch_b.cpu(), np.asarray([0, 1]))
np.testing.assert_allclose(
batch_c,
batch_c.cpu(),
np.asarray(
[
[0],
Expand Down