Harden PythonInterpreter agains pyenv shims. #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Pex encounered hard to diagnose errors when selected interpreters were pyenv shims. These shim files can represent a different interpreter on different executions which broke Pex's assumption that a given binary always corresponded to a given python version. Since we already shell out to an interpreter to gather its `PythonIdentity`, we now include collecting the real final interpeter path from `sys.executable` there. This allows pex to see through a shim to the underlying `$PYENV_ROOT/versions/<version>/bin/python*` interpreter which conforms to the expectation of a given binary corresponding to a given python version. See: pyenv/pyenv#1112 Debugged working pex-tool#856 which hit otherwise un-explainable errors in `tests/test_pex_bootstrapper.py`. Work towards pex-tool#782.
Eric-Arellano
approved these changes
Jan 23, 2020
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Oct 9, 2020
The prior fix for pex-tool#1009 undid the fix in pex-tool#860. Re-enable that fix for any case that's clearly not in the context of a macOS Framework Python build. Also add tests for pyenv shims to prevent further regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Pex encounered hard to diagnose errors when selected
interpreters were pyenv shims. These shim files can represent a
different interpreter on different executions which broke Pex's
assumption that a given binary always corresponded to a given python
version.
Since we already shell out to an interpreter to gather its
PythonIdentity, we now include collecting the real final interpeterpath from
sys.executablethere. This allows pex to see through a shimto the underlying
$PYENV_ROOT/versions/<version>/bin/python*interpreter which conforms to the expectation of a given binary
corresponding to a given python version.
See: pyenv/pyenv#1112
Debugged working #856 which hit otherwise un-explainable errors in
tests/test_pex_bootstrapper.py.Work towards #782.