Re-enable pyenv interpreter tests under pypy. #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out the fundamental issue was a bad version of curl which was actually hinted at by the dump originally included in pex-tool#477. We've since updated our linux image to bionic which happened to fix the issue moving to a newer curl as a side-effect. This change re-enables disabled tests as well as converting a test skipped previously due to this blanket issue to a more specific, legitimate skip. The `.travis.yml` is also cleaned up a bit. The hint this might be worth pursing came from: unbit/uwsgi#37 (comment) Fixes pex-tool#477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out the fundamental issue was a bad version of curl which was
actually hinted at by the dump originally included in #477. We've since
updated our linux image to bionic which happened to fix the issue moving
to a newer curl as a side-effect.
This change re-enables disabled tests as well as converting a test
skipped previously due to this blanket issue to a more specific,
legitimate skip. The
.travis.ymlis also cleaned up a bit.The hint this might be worth pursing came from:
unbit/uwsgi#37 (comment)
Fixes #477