Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support - when running as an interpreter. #543

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 22, 2018

It's surprising when using a pex in python interpreter mode that - is
not recognized as a program coming from stdin as regular python
interpreter would. Add support for this with a test.

The surprise of this missing feature was rightly identified in the
context of pantsbuild/pants#6275.

It's surprising when using a pex in python interpreter mode that `-` is
not recognized as a program coming from stdin as regular python
interpreter would. Add support for this with a test.

The surprise of this missing feature was rightly identified in the
context of pantsbuild/pants#6275.
Copy link
Contributor

@cosmicexplorer cosmicexplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to do this by modifying something completely different and I was very confused as to why it wasn't changing anything so this is a super useful fix.

@jsirois jsirois merged commit 927433a into pex-tool:master Aug 24, 2018
@jsirois jsirois deleted the interpreter/support_stdin_file_arg branch August 24, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants