Preserve perms of files copied to pex chroots. #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing tests are added that now pass. Fixes pex-tool#536
benjyw
approved these changes
Aug 19, 2018
kwlzn
approved these changes
Aug 21, 2018
| @@ -348,7 +348,7 @@ def __str__(self): | |||
| def delete(self): | |||
| shutil.rmtree(self.chroot) | |||
|
|
|||
| def zip(self, filename, mode='wb'): | |||
| def zip(self, filename, mode='w'): | |||
There was a problem hiding this comment.
opening a zip in non-binary mode strikes me as a bit odd.. what's the reasoning behind this?
There was a problem hiding this comment.
It's not even a thing! That was a bug. Zipfile only supports a subset of modes - this is not an open pass-thru.
There was a problem hiding this comment.
To be more clear, the one user passed mode='a', avoiding the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests are added that now pass.
Fixes #536