Pass allow_prerelease to other iterators (Static, Caching) #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddgardner
changed the title
|
I found another issue of the same nature, where allow_prerelease wasn't being passed to StaticIterator either, this meant two requirements like I rolled it into this change since it touched the same code. Note this will have to be updated if #374 is accepted as it includes defaults that should be updated. |
|
+1 |
|
@toddgardner - #374 is now merged, please update. |
Closed
toddgardner
force-pushed
the
todd-prelease-cache
branch
from
c0323a5 to
2a8f19b
Compare
|
Updated and added some tests for the defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best way to do this or test this, but while investigating another bug I noticed caching resolver always ignored prerelease versions, as it constructed it's own iterator and didn't take into account the options passed on resolve. This fixes that and tests it.