Eliminate warnings for default use. #2188
Conversation
Previously `pex` would warn for default usage scenarios under both Python 3.11 and Python 3.12. For Python 3.12, the `--pip-version` defaulted to 23.2 but a warning about vendored Pip 20.3.4 was issued anyway; this is now fixed. For both Python 3.11 and Python 3.12, the vendored version of packaging used the deprecated `sre_constants` stdlib module; this is now fixed with packaging 23.1 being vendored and selected for Python >= 3.7. Fixes pex-tool#2186
| # N.B.: The pyparsing constraint is needed because our import re-writer (RedBaron) chokes on | ||
| # newer versions. | ||
| yield VendorSpec.pinned( | ||
| "packaging", "21.3", import_path="packaging_21_3", constraints=("pyparsing<3",) | ||
| ) | ||
| if not filter_requires_python or sys.version_info[:2] >= (3, 7): |
There was a problem hiding this comment.
This 3rd vendored version of packaging increases Pex size ~100k from 4103623 bytes to 4205804 bytes.
| @@ -886,8 +886,8 @@ def main(args=None): | |||
| except target_configuration.InterpreterConstraintsNotSatisfied as e: | |||
| die(str(e), exit_code=CANNOT_SETUP_INTERPRETER) | |||
|
|
|||
| resolver_configuration = finalize_resolve_config( | |||
| resolver_configuration, targets, context="PEX building" | |||
| resolver_configuration = try_( | |||
There was a problem hiding this comment.
The new test caught this old bug.
| @@ -59,7 +59,7 @@ def build_pex_pex(output_file: PurePath, verbosity: int = 0) -> None: | |||
|
|
|||
| def describe_git_rev() -> str: | |||
| git_describe = subprocess.run( | |||
| ["git", "describe"], check=True, capture_output=True, encoding="utf-8" | |||
| ["git", "describe"], check=True, stdout=subprocess.PIPE, encoding="utf-8" | |||
There was a problem hiding this comment.
Testing the packaging and pytest Python 3.6 edge case (tox -epy36-integration) caught this bug: capture_output was only added in 3.7. CI only runs unit tests for 3.5, ITs start at 3.7.
|
Hrm, so packaging 22.0+ drop support for ... I guess I can just only use packaging 23.1 for Python>=3.12. The Python 3.11 folks have been suffering the warning already and the only folks not broken are 3.12 users mod a few hours. Aha - ok, this is a test artifact. The |
When the operator is `===`, we now perform the comparison on our own since modern packaging errors. We also emit `===` in PEX-INFO when an embedded distribution has a non PEP-440 compliant version.
| @@ -21,11 +21,14 @@ def test_pip_2020_resolver_engaged(): | |||
|
|
|||
| # The Pip legacy resolver cannot solve the following requirements but the 2020 resolver can. | |||
| # Use this fact to prove we're plumbing Pip resolver version arguments correctly. | |||
| pex_args = ["boto3==1.15.6", "botocore>1.17<1.18.7", "--", "-c", "import boto3"] | |||
| pex_args = ["boto3==1.15.6", "botocore>1.17,<1.20", "--", "-c", "import boto3"] | |||
There was a problem hiding this comment.
Modern packaging switched from pyparsing to a be-spoke parser and fixed the parsing bug that allowed botocore>1.17<1.18.7 previously (missing comma / AND). The <1.18.7 -> <1.20 is to force a naive conflict that pip-legacy-resolver can't handle - the actual point of the test. That version, 1.19.63, is now encoded in the test assertions.
Previously
pexwould warn for default usage scenarios under bothPython 3.11 and Python 3.12. For Python 3.12, the
--pip-versiondefaulted to 23.2 but a warning about vendored Pip 20.3.4 was issued
anyway; this is now fixed. For both Python 3.11 and Python 3.12, the
vendored version of packaging used the deprecated
sre_constantsstdlib module; this is now fixed with packaging 23.1 being vendored
and selected for Python >= 3.7.
Fixes #2186