Add support for selecting packages and modules. #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This complements the existing `-D` / `--sources-directory` support for adding local sources and resources with finer-grained control over what files are included in the PEX file. Notably, this allows cleanly packaging projects with no `setup.py` / `pyproject.toml` based build when the projects have their Python code at the top level mixed with other files that should not be included in the PEX (e.g.: build scripts, CI configuration, documentation, etc.). Fixes pex-tool#2134
|
N.B.: I wanted to convert this Pex PEX packaging to dogfood via Tests caught the fact that folks rely on the pex3 console script though (Pants for one via |
|
@lordmauve / @khaledh, if either of you is available to take a look, I'd be grateful. |
benjyw
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements the existing
-D/--sources-directorysupport foradding local sources and resources with finer-grained control over
what files are included in the PEX file. Notably, this allows cleanly
packaging projects with no
setup.py/pyproject.tomlbased buildwhen the projects have their Python code at the top level mixed with
other files that should not be included in the PEX (e.g.: build scripts,
CI configuration, documentation, etc.).
Fixes #2134