Prepare for Pip 23.2 release. #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent Pip commit has broken `pip --use-deprecated legacy-resolver download ...` which is our backwards-compatible default use case. Whether or not Pip decides to fix, the legacy resolver will be yanked at some point and it seems reasonable to just require any Pex user on Python 3.12 and thus Pip 23.2 to only use the Pip 2020 resolver. See: pypa/pip#12138
kaos
approved these changes
Jul 11, 2023
|
Thanks for taking a look @kaos. |
jsirois
commented
Jul 11, 2023
| def _supports_legacy_resolver(pip_version=None): | ||
| # type: (Optional[PipVersionValue]) -> bool | ||
| pip_ver = pip_version or PipVersion.DEFAULT | ||
| return pip_ver.version < Version("23.2") |
There was a problem hiding this comment.
It looks like the underlying issue will get fixed before 23.2 is released (pypa/pip#12140). I'll probably follow up, leaving all the code in this change in place but changing this function to just return True for all cases so that < Version("X.Y.Z") can go back in when Pip does actually drop support for the legacy resolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent Pip commit has broken
pip --use-deprecated legacy-resolver download ...which is ourbackwards-compatible default use case. Whether or not Pip decides to
fix, the legacy resolver will be yanked at some point and it seems
reasonable to just require any Pex user on Python 3.12 and thus Pip 23.2
to only use the Pip 2020 resolver.
See: pypa/pip#12138