Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release announcements. #2167

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jul 2, 2023

This re-uses the scie-pants & a-scie infra and converts CHANGES.rst to
CHANGES.md so that infra can be used as-is.

This re-uses the scie-pants & a-scie infra and converts CHANGES.rst to
CHANGES.md so that infra can be used as-is.
draft: false
prerelease: false
files: dist/pex
fail_on_unmatched_files: true
discussion_category_name: Announcements
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the Announcements GH discussions category just now.

]
}
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added pantsbuild/pex to the list of repos this org secret is exposed to.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, you noticed I added it at the org level. This should mean we can delete it from scie-pants, but I wanted to test first.

@jsirois jsirois requested a review from benjyw July 2, 2023 19:18
@benjyw
Copy link
Collaborator

benjyw commented Jul 2, 2023

BTW I have set up SES and had it moved out of the AWS sandbox, so we can also send email automatically now. I will get that set up in the main pantsbuild repo soon to demonstrate.

@jsirois
Copy link
Member Author

jsirois commented Jul 2, 2023

Ok. I have no clue what an SES is. Pex has never sent an email so I don't think I'll start unless the pantsbuild org has some strong reason to.

@jsirois
Copy link
Member Author

jsirois commented Jul 2, 2023

I imagine you know about this, but in case not, seems free no extra AWS needed?: https://github.com/marketplace/actions/send-email

Last I used Google smtp was in maybe 2009, but it worked then anyhow for a personal account like pantsbuild@gmail.com.

@benjyw
Copy link
Collaborator

benjyw commented Jul 2, 2023

Yeah, I looked at that, but AFAICT it means CI must know pantsbuild@gmail.com's account password, which, since we use that account for a bunch of things, seemed imprudent.

I suppose I could have created pantsbuild-announce@gmail.com or something, but SES was easy to set up, and we already use AWS for other stuff.

And that was just FYI, I see no need to introduce new emails where there weren't any before.

@jsirois jsirois merged commit e6b4053 into pex-tool:main Jul 2, 2023
@jsirois jsirois deleted the release/announce/automate branch July 2, 2023 20:48
jsirois added a commit to jsirois/pex that referenced this pull request Jul 24, 2023
This was fallout from the CHANGES.rst -> CHANGES.md to support automated
release announcements in pex-tool#2167.
jsirois added a commit that referenced this pull request Jul 24, 2023
This was fallout from the CHANGES.rst -> CHANGES.md to support automated
release announcements in #2167.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants