Guard against cyclic dependency graphs. #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip can resolve through cycles at build time but Pex was failing to match this at run time. Ensure we don't enter an infinite runtime resolve loop in the presence of cycles and add a test that previously failed with inifinite runtime recursion. Fixes pex-tool#1316
Eric-Arellano
approved these changes
Apr 5, 2021
jsirois
referenced
this pull request
in jsirois/pants
Apr 22, 2021
The relevant changelog: 2.1.40 ------ This release brings proper support for pyenv shim interpreter identification as well as a bug fix for venv mode. * Fix Pex venv mode to respect ``--strip-pex-env``. (pantsbuild#1329) `PR pantsbuild#1329 <https://github.com/pantsbuild/pex/pull/1329>`_ * Fix pyenv shim identification. (pantsbuild#1325) `PR pantsbuild#1325 <https://github.com/pantsbuild/pex/pull/1325>`_ 2.1.39 ------ A hotfix that fixes a bug present since 2.1.25 that results in infinite recursion in PEX runtime resolves when handling dependency cycles. * Guard against cyclic dependency graphs. (pantsbuild#1317) `PR pantsbuild#1317 <https://github.com/pantsbuild/pex/pull/1317>`_ Work towards pantsbuild#11946. [ci skip-rust] [ci skip-build-wheels]
jsirois
referenced
this pull request
in pantsbuild/pants
Apr 22, 2021
The relevant changelog: 2.1.40 ------ This release brings proper support for pyenv shim interpreter identification as well as a bug fix for venv mode. * Fix Pex venv mode to respect ``--strip-pex-env``. (#1329) `PR #1329 <https://github.com/pantsbuild/pex/pull/1329>`_ * Fix pyenv shim identification. (#1325) `PR #1325 <https://github.com/pantsbuild/pex/pull/1325>`_ 2.1.39 ------ A hotfix that fixes a bug present since 2.1.25 that results in infinite recursion in PEX runtime resolves when handling dependency cycles. * Guard against cyclic dependency graphs. (#1317) `PR #1317 <https://github.com/pantsbuild/pex/pull/1317>`_ Work towards #11946.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip can resolve through cycles at build time but Pex was failing to
match this at run time. Ensure we don't enter an infinite runtime
resolve loop in the presence of cycles and add a test that previously
failed with inifinite runtime recursion.
Fixes #1316