Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type BuildAndInstallRequest. #1169

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Type BuildAndInstallRequest. #1169

merged 2 commits into from
Jan 12, 2021

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jan 12, 2021 •
edited
Loading

Work towards #899.

@jsirois
Copy link
Member Author

jsirois commented Jan 12, 2021 •
edited
Loading

Depends on #1167 (2f2fadd) and #1168 (2229d24). Please just review 59614c5.

@jsirois jsirois force-pushed the issues/899/type_build_and_install branch from 3ebfda2 to 59614c5 Compare January 12, 2021 15:10
Eric-Arellano
Eric-Arellano approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks!

pex/resolver.py Show resolved Hide resolved
@jsirois jsirois force-pushed the issues/899/type_build_and_install branch from b59a33e to 8376a73 Compare January 12, 2021 16:15
@jsirois jsirois merged commit 4dcca2d into pex-tool:master Jan 12, 2021
@jsirois jsirois deleted the issues/899/type_build_and_install branch January 12, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirois @Eric-Arellano