Implement PEX_INTERPRETER special mode support. #1149
Conversation
This brings the venv pex script up to parity with PEX files. Fixes pex-tool#1136
| else pex_overrides.get("PEX_MODULE", {entry_point!r} or "code:interact") | ||
| PEX_INTERPRETER_ENTRYPOINT | ||
| if pex_interpreter | ||
| else pex_overrides.get("PEX_MODULE", {entry_point!r} or PEX_INTERPRETER_ENTRYPOINT) | ||
| ) |
There was a problem hiding this comment.
Are we trending toward this codepath replacing the existing codepath, or are we expecting them to live in parallel for the medium future? Not terribly complicated, but if it's going to continue to grow, some sort of de-duplication might be in order.
There was a problem hiding this comment.
I expect these to live in parallel for the foreseeable future. That aside, fhe factored out code could never use anything but the stdlib which we'd need infra to check / enforce and it might have to get tortured slightly to deal with PEX needing to demote its bootstrap at the right point in time in the different branches. Not sure about the last bit - may be a non-problem. May be worth doing, but the test coverage here seems sufficient to punt doing that.
There was a problem hiding this comment.
Ah yeah - the grow question - no growth. This should be the last for PEX_INTERPRETER handling until some new Python release adds new interpreter options that make sense for PEX-as-an-interpreter to support.
This brings the venv pex script up to parity with PEX files.
Fixes #1136