-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEX runtime warnings should have a knob to squelch #677
Comments
I’d propose turning on by default, and making it very clear how to turn it off. If we default to off, I’m concerned few would discover it’s even an option. For the 3rd party dependency issue, if we default to the messages being on then we may need a way to silence the errors other than a CLI flag to PEX, such as using an env var. |
Since these are runtime warnings, we can't really use a flag unless we co-opt
|
I agree env var is not ergonomic. We certainly wouldn’t expect someone to have to permanently source it from their I like the build time option the most. I like it because it has a sensible default and will provide instructions for how to turn it off permanently for that PEX. The decision is also per-PEX, in that you might want to silence for one but keep for another, which is good to not assume the user wants something global. |
Previously warnings were emitted to stderr unconditionally, but now both build-time and run-time controls are provided. At build-time --no-emit-warnings can be specified and a pex will be produced that does not emit warnings. At run-time, PEX_EMIT_WARNINGS and PEX_VERBOSE can be used to toggle warning behavior. Fixes pex-tool#677
Previously warnings were emitted to stderr unconditionally, but now both build-time and run-time controls are provided. At build-time --no-emit-warnings can be specified and a pex will be produced that does not emit warnings. At run-time, PEX_EMIT_WARNINGS and PEX_VERBOSE can be used to toggle warning behavior. Fixes pex-tool#677
Previously warnings were emitted to stderr unconditionally, but now both build-time and run-time controls are provided. At build-time --no-emit-warnings can be specified and a pex will be produced that does not emit warnings. At run-time, PEX_EMIT_WARNINGS and PEX_VERBOSE can be used to toggle warning behavior. Fixes #677
I'm not sure the knob should default on or off, but some from of warning control makes sense since once a pex is built, it will emit this warning on every run which does not seem useful past the first time a human acknowledges the issue - which they may not even be able to fix easily if due to 3rdparty deps.
The text was updated successfully, but these errors were encountered: