-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pex fails to layout venvs properly. #1630
Comments
In the PEX case, the RECORD is different with - apparently - one too few
Pex will need to adjust for that assuming that's a consistent result. |
The RECORD being different / wrong for The |
As usual, the variety present in the PyPA ecosystem made this interesting. |
This uses the RECORD as the basis for determining which files to copy and where they belong, fixing the issues with data files not being properly located. Fixes #1630
There is probably a bug here for unzip mode too.
For example, via Pip:
But via Pex:
So Pex is failing to read the RECORD to determine final relative resting paths in the venv. It currently special-cases
bin
with this code instead of using the RECORD so gets away with the vast majority of use cases, but not all!:https://github.com/pantsbuild/pex/blob/f931befd5ed96d343f2182f34c403bc8bfb188fe/pex/tools/commands/venv.py#L191-L196
The text was updated successfully, but these errors were encountered: