Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Unit Testing Infrastructure #1

Merged
merged 34 commits into from
Oct 18, 2024

Conversation

mwaxmonsky
Copy link
Collaborator

Adds unit tests to run as a part of the github actions for each pull request and commit to the sima-history branch.

@mwaxmonsky mwaxmonsky marked this pull request as ready for review August 12, 2024 13:09
@mwaxmonsky
Copy link
Collaborator Author

@peverwhee @nusbaume This should be good to go now. Apologies for the delay, went down the rabbit hole with CISL on containers. The only thing that might be useful at add is detailed web output from gcovr (https://gcovr.com/en/stable/output/html.html) which I can add if desired, it just might make the output large to have a bunch of html files uploaded as artifacts.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have one request/comment.

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me now, thanks!

Copy link
Owner

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question and a couple requests for comments.

.github/workflows/code-coverage.yml Show resolved Hide resolved
test/test_hash_table.pf Outdated Show resolved Hide resolved
test/test_hashable.pf Outdated Show resolved Hide resolved
@mwaxmonsky mwaxmonsky requested a review from peverwhee October 15, 2024 15:58
@mwaxmonsky mwaxmonsky self-assigned this Oct 16, 2024
Copy link
Owner

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small things!

test/test_hash_table.pf Outdated Show resolved Hide resolved
test/test_hash_table.pf Outdated Show resolved Hide resolved
test/test_hashable.pf Show resolved Hide resolved
@mwaxmonsky mwaxmonsky requested a review from peverwhee October 18, 2024 12:54
@mwaxmonsky mwaxmonsky merged commit f03b89e into peverwhee:sima-history Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants