-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Initial Unit Testing Infrastructure #1
Conversation
@peverwhee @nusbaume This should be good to go now. Apologies for the delay, went down the rabbit hole with CISL on containers. The only thing that might be useful at add is detailed web output from gcovr (https://gcovr.com/en/stable/output/html.html) which I can add if desired, it just might make the output large to have a bunch of html files uploaded as artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have one request/comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me now, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question and a couple requests for comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small things!
Adds unit tests to run as a part of the github actions for each pull request and commit to the
sima-history
branch.