Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added C++ support #41

Merged
merged 3 commits into from
Apr 7, 2019
Merged

added C++ support #41

merged 3 commits into from
Apr 7, 2019

Conversation

Bhupesh-V
Copy link

Added C++ snippets from 30 Seconds of C++

@petrovicstefanrs
Copy link
Owner

I'll need to add an option to support c++ first. Then we can merge this, however the folder for c++ can't be named "c++" it should be "cpp". Also if there is a repo where you have all these snippets could you link to it here so others can help with migrating the snippets.

@Bhupesh-V
Copy link
Author

Bhupesh-V commented Mar 18, 2019

Ok I have changed the directory name to cpp
I will be adding C++ snippets to this directory.
Also ping me when you will be adding support for C++ , I will provide you with the logo 😃

@petrovicstefanrs
Copy link
Owner

@Bhupesh-V Hey man, I've started merging all PRs and I'm just about to merge C++ snippets, I don't however want to release them before we have at least 20-30 snippets. So the question is, do you have more snippets or is this all? 😄

@Bhupesh-V
Copy link
Author

@Bhupesh-V Hey man, I've started merging all PRs and I'm just about to merge C++ snippets, I don't however want to release them before we have at least 20-30 snippets. So the question is, do you have more snippets or is this all?

Hey 😄 sure , I have added more snippets(26 in total) also do I have to push a template for C++ Snippets in the templates/ directory ?
I will also ping you once the Logo is ready

@petrovicstefanrs
Copy link
Owner

petrovicstefanrs commented Apr 7, 2019

@Bhupesh-V Hey, I'll actually push the template and I made some changes so next time you create snippets use the new template, as for the logo there is no need for it. If you are taking the snippets from a separate repo do send me a link so I can backlink to the original repo in readme and on other places :D

@petrovicstefanrs petrovicstefanrs merged commit f8cf184 into petrovicstefanrs:dev Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants