Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack trace for warnings https://github.com/petkaantonov/bluebird… #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jehy
Copy link

@jehy jehy commented Oct 2, 2018

Sample pull request for #1552

@benjamingr
Copy link
Collaborator

@petkaantonov

@iwko
Copy link

iwko commented Oct 9, 2018

Those changes are not included in tests

Copy link

@iwko iwko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test

@jehy
Copy link
Author

jehy commented Oct 23, 2018

I am not sure that stack trace should really be implemented, am I am not sure that it should be added this way. This PR is just an example. I think that this topic needs more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants