Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of UTF-8 #42

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Support of UTF-8 #42

merged 4 commits into from
Jul 8, 2023

Conversation

Joe91
Copy link
Contributor

@Joe91 Joe91 commented Jul 8, 2023

This is just a proposal.
With these changes the FTP-Server adds support for UTF-8 and for white-spaces in filenames and folders.
Also Filezille now detects the UTF-8 mode if set to "automatic-detection".

Since UTF-8 is fully supported by Arduino 2 filesystems there should be no problem to enable this.
But it would also be possible to only enable UTF-8 support if you configure it when adding the filesystem.

Thanks a lot for this great FTP-Server! It really works great for me :-) ...

@peterus
Copy link
Owner

peterus commented Jul 8, 2023

@Joe91 thank you very much for your contribution! I will fix the style check etc. than I will merge your changes 😉

@Joe91
Copy link
Contributor Author

Joe91 commented Jul 8, 2023

Oh, sorry for the style-error.
So do you want the support for spaces and utf-8? I was not sure wether it was inteded the way it was...
If you like we can also put this changed behaviour on an option (for example in the register-function of the filesystem).

@peterus
Copy link
Owner

peterus commented Jul 8, 2023

I like your changes! Don't worry ;) I will fix the last issue and than merge everything :) thanks for your support!

@peterus peterus enabled auto-merge July 8, 2023 18:12
@peterus
Copy link
Owner

peterus commented Jul 8, 2023

closing #41

@peterus peterus merged commit 44e0a17 into peterus:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants