Hotfix/gh404 lost center global flex issue #405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 701 701
=====================================
Hits 701 701
Continue to review full report at Codecov.
|
|
Hey Peter, Sorry I've been awol for so long, I've been absolutely snowed under at work. I'm actually finishing my current project today, so your timing is absolutely spot on! I should have time to take a look at this tomorrow for you, hopefully it can wait until then. All the best, |
|
Funny ‘cause I’ve been the same way. Being snowed under with work is never a bad thing, though! Glad you’re staying busy! |
lib/lost-center.js
Outdated
| @@ -32,6 +36,8 @@ module.exports = function lostCenterDecl(css, settings, result) { | |||
| lostCenterFlexbox = 'no-flex'; | |||
| } | |||
|
|
|||
| lostCenterFlexbox = lgLogic.parseLostProperty(decl.parent.nodes, 'lost-center-flexbox', lostCenterFlexbox); | |||
|
|
|||
There was a problem hiding this comment.
Did you mean to leave this line blank? Wasn't sure it it was significant? If it is I'll shut up, otherwise it would neaten it up a very tiny bit :)
There was a problem hiding this comment.
You're not the first person who's commented on my whitespace. I love it to a fault. I'll clean that up! Thanks for catching that!
What kind of change is this? (Bug Fix, Feature...)
Bugfix
What is the current behavior (You can also link to an issue)
See #404
What is the new behavior this introduces (if any)
Fixes #404 to act as it should
Does this introduce any breaking changes?
I certainly hope not
Does the PR fulfill these requirements?
- [ ] Docs have been added or updated