Lost center fraction #365
Merged
Lost center fraction #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phew...sorry I've been silent. Life apparently? 🕺 I only have a few minutes to review this–so I'm gonna leave some inline comments...mainly for myself to double check my own assumptions. Event though I wrote the code sometimes I forget how things work. Initial glance has me super stoked to have you helping out! It looks awesome! I should have some time to do a deep dive on Thursday evening Pacific time. |
peterramsing
reviewed
Apr 5, 2017
| /** | ||
| * lost-center: Horizontally center a container element and apply padding | ||
| * to it. | ||
| * | ||
| * @param {length} [max-width] - A max-width to assign. Can be any unit. |
There was a problem hiding this comment.
@codebysubtract With these edits here, do you have any thoughts on: #364
| lostCenterFlexbox = declaration.value; | ||
| } | ||
| if (!lgLogic.validateUnit(lostUnit, validUnits)) { | ||
| decl.warn(result, `${lostUnit} is not a valid unit for lost-center`); |
peterramsing
added
status: In Progress
component: lost-center
type: Enhancement
and removed
status: Backlog
labels
peterramsing
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this? (Bug Fix, Feature...)
Feature Enhancement
What is the current behavior (You can also link to an issue)
Allow for fractions to be used within lost-center #361
What is the new behavior this introduces (if any)
Being able to use a fraction w/in lost-center
Does this introduce any breaking changes?
No
Does the PR fulfill these requirements?
Other Comments