Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Editor Config to project #212

Merged
merged 1 commit into from
Jan 2, 2016
Merged

Adds Editor Config to project #212

merged 1 commit into from
Jan 2, 2016

Conversation

peterramsing
Copy link
Owner

Indent style should be a space
Indent size should be 2

Indent style should be a space
Indent size should be 2
@peterramsing
Copy link
Owner Author

This is the "generic" but should other editors that don't support this get their own config? Or should this be done by linting instead?

@peterramsing peterramsing self-assigned this Dec 30, 2015
@peterramsing peterramsing added this to the 6.7.x - Minor Updates milestone Dec 30, 2015
@peterramsing peterramsing changed the title Adds Editor Config File Adds Editor Config to project Dec 30, 2015
@corysimmons
Copy link
Contributor

I think .editorconfig is perfectly fine.

@peterramsing
Copy link
Owner Author

I'll merge this after I finalize a way of tracking a changelog. I think this is goo to go, then.

@corysimmons
Copy link
Contributor

When you release a new package via NPM, you should make a release with changelog notes.

I used to maintain CHANGELOG.md's with all my projects until I noticed I was just copy-pasting everything from my changelog to my release notes. /$.02

@peterramsing
Copy link
Owner Author

I suppose I mean for the dev cycle, where is the changelog? I could keep the change written on my desktop till the release but that doesn't pass the bus test. 🚌

@peterramsing
Copy link
Owner Author

If you haven't noticed yet, I'm a man all about the process. ✅ 😄

@corysimmons
Copy link
Contributor

I'm not sure what you mean by dev cycle. Good commits should have information regarding what was in the commit, and the releases can be a good overview of those changes.

Are you talking about keeping an actual CHANGELOG file?

@peterramsing
Copy link
Owner Author

It's a small thing, really. At work we have different holding spots for tickets. After they are merged they get put in a new spot saying they're merged but not released. When releasing you go and see all the tickets merged but not released and add them to the changelog.

You're right in saying the commits should hold the keys, but sometimes they don't. I want a place to know all the features coming down the pipe. I think that an issue for each feature in the milestone is sufficient but want to go slow and smart to ensure process stability.

@corysimmons
Copy link
Contributor

For what it's worth, I'm totally not against you having a CHANGELOG. If it helps you in any way, go for it. =)

@peterramsing
Copy link
Owner Author

I'm going to try this out by using the Milestone

peterramsing added a commit that referenced this pull request Jan 2, 2016
@peterramsing peterramsing merged commit 71e4ade into 6.7.0 Jan 2, 2016
@peterramsing peterramsing mentioned this pull request Jan 20, 2016
5 tasks
@peterramsing peterramsing deleted the adds-editor-config branch January 25, 2016 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants