Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds lost-column: none for unsetting a lost-column rule and enhances README #179

Closed
wants to merge 6 commits into from
Closed

Adds lost-column: none for unsetting a lost-column rule and enhances README #179

wants to merge 6 commits into from

Conversation

peterramsing
Copy link
Owner

Regarding the conversation happening in #150 (unsetting lost-column)

@peterramsing
Copy link
Owner Author

@corysimmons What are your thoughts? Too much of a hack?

@corysimmons
Copy link
Contributor

Looks good. Care to add a test?

@peterramsing
Copy link
Owner Author

I'll look into that. I'm flying back home tonight so I'll write those on the plane if I have any battery left. :)

@peterramsing
Copy link
Owner Author

@corysimmons Do you have any thoughts on the syntax? lost-column: none work?
I'll also add in documentation for it.

@corysimmons
Copy link
Contributor

Yeah lost-column: none seems fine.

@peterramsing
Copy link
Owner Author

"unset"? https://developer.mozilla.org/en-US/docs/Web/CSS/unset

@corysimmons
Copy link
Contributor

  • none
  • unset
  • reset
  • inherit

I'm fine with any of those. =)

@peterramsing
Copy link
Owner Author

When I am working on the final pieces on the plane tonight I'll see what feels the best. :) I still want to test some more odd use cases...but it looks like it's working well.

@peterramsing
Copy link
Owner Author

Bah–I'll look at why that failed and fix it...but it might have to wait till morning...

@peterramsing
Copy link
Owner Author

@corysimmons Back to you. Sorry about the copy-pasta...it's been a long weekend/early week...and next time I'll run the tests on my machine... face-palm

@peterramsing peterramsing changed the title [WIP] initial work on unsetting the lost-column rule. initial work on unsetting the lost-column rule. Oct 7, 2015
@peterramsing peterramsing changed the title initial work on unsetting the lost-column rule. Adds lost-column: none for unsetting a lost-column rule Oct 7, 2015
@peterramsing
Adds the processed css from example lost-grid syntax to the README an…
30badb7 
…d states the lost-utility: edit color

- adds the compiled css after the lost-grid syntax is compiled by
postcss to the README.
- adds the color value of the lost-utility of edit to the README
- adds attribution
@peterramsing peterramsing changed the title Adds lost-column: none for unsetting a lost-column rule Adds lost-column: none for unsetting a lost-column rule and enhances README Nov 28, 2015
@peterramsing peterramsing mentioned this pull request Nov 28, 2015
Closed
@peterramsing peterramsing self-assigned this Dec 29, 2015
@peterramsing
Copy link
Owner Author

Closing this in leu of #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peterramsing peterramsing

Labels
component: lost-column type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterramsing @corysimmons